Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] workqueue metrics are mising #5954

Open
8 of 10 tasks
RainbowMango opened this issue Dec 14, 2024 · 2 comments
Open
8 of 10 tasks

[bugfix] workqueue metrics are mising #5954

RainbowMango opened this issue Dec 14, 2024 · 2 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@RainbowMango
Copy link
Member

RainbowMango commented Dec 14, 2024

What happened:
We received reports that the controller's work queue metrics can not be emitted. (See #5945 for more details, thanks to @CharlesQQ for reporting this).

This issue occurred before and was fixed in release 1.0 in #945, and then we made some subsequent impairments in #2899 and #3012. (Thanks to @Garrybest for doing this)

However after #2998 and #4706, this issue was introduced again in release-1.10.

This issue is used to track any relevant fix to ensure the problem is fully resolved without introducing any potential risk.

Root Cause:
TBD

Iteration tasks:

Other Potential risks

References:

  • From Go 1.21, the program initialization order was specified more precisely. See Go 1.21 release notes for more details.

Echo from the release notes:

Package initialization order is now specified more precisely. The new algorithm is:

  • Sort all packages by import path.
  • Repeat until the list of packages is empty:
    • Find the first package in the list for which all imports are already initialized.
    • Initialize that package and remove it from the list.
@RainbowMango RainbowMango added the kind/bug Categorizes issue or PR as related to a bug. label Dec 14, 2024
@RainbowMango RainbowMango added this to the v1.13 milestone Dec 14, 2024
@RainbowMango RainbowMango changed the title workqueue metrics are mising [bugfix] workqueue metrics are mising Dec 18, 2024
@RainbowMango RainbowMango moved this to Planned In Release 1.13 in Karmada Overall Backlog Dec 18, 2024
@RainbowMango RainbowMango added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 24, 2024
@chaosi-zju
Copy link
Member

the PR #6003 works for the task Introduce tests to cover the metrics

@RainbowMango
Copy link
Member Author

Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: Planned In Release 1.13
Development

No branches or pull requests

2 participants