Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added environment variables to control bind address #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added environment variables to control bind address #23

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
235d442
Added environment variables to control bind address
sorucoder Dec 14, 2024
778648d
Added defaults for $HOST and $PORT via script.
sorucoder Dec 18, 2024
95d0d90
Simplified default setting for $HOST and $PORT
sorucoder Dec 18, 2024
f8c1de3
Changed script shebangs to use BASH instead of sh
sorucoder Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion docker/scripts/startup-webserver.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,15 @@ sleep 2

echo "[INFO] launching chromium instance"

if [ -z $HOST ]; then
echo "[ERROR] Missing environment variable \$HOST."
exit 1
fi

if [ -z $PORT ]; then
echo "[ERROR] Missing environment variable \$PORT."
exit 1
fi

# Run python script on display 0
DISPLAY=:99 python potoken-generator.py --bind 0.0.0.0
DISPLAY=:99 python potoken-generator.py --bind $HOST --port $PORT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no default value for $HOST. There is a need to have 0.0.0.0 as the host address.

Either you define this default value in the bash script or you pass it in the Dockerfile.

Copy link
Author

@sorucoder sorucoder Dec 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed via commit 778648d.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you instead make it simplier using this method: https://stackoverflow.com/questions/2013547/assigning-default-values-to-shell-variables-with-a-single-command-in-bash?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will.

However, isn't that a bash only feature? I thought sh doesn't support that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha yes. Feel free to switch the shabang to ash since this is based on alpine.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with commits 95d0d90 and f8c1de3.