Added environment variables to control bind address #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unixfox
requested changes
Dec 16, 2024
| # Run python script on display 0 | ||
| DISPLAY=:99 python potoken-generator.py --bind 0.0.0.0 | ||
| DISPLAY=:99 python potoken-generator.py --bind $HOST --port $PORT |
There was a problem hiding this comment.
There is no default value for $HOST. There is a need to have 0.0.0.0 as the host address.
Either you define this default value in the bash script or you pass it in the Dockerfile.
There was a problem hiding this comment.
Can you instead make it simplier using this method: https://stackoverflow.com/questions/2013547/assigning-default-values-to-shell-variables-with-a-single-command-in-bash?
There was a problem hiding this comment.
Yes, I will.
However, isn't that a bash only feature? I thought sh doesn't support that.
There was a problem hiding this comment.
Ha yes. Feel free to switch the shabang to ash since this is based on alpine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fulfilling wishes of #19.
This PR should allow to set the host and port of the webserver like so:
I can't test it in docker due to unfamiliarity with it but I know my shell scripting. hope this helps.