-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: zksync support for core solidity package #5290
base: main
Are you sure you want to change the base?
feat: zksync support for core solidity package #5290
Conversation
🦋 Changeset detectedLatest commit: 1f19a12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to zksync conditional building. Since zksync functions are a part of core-utils and zksync classes on sdk expect a value, we need to feed them some default values not to break build process. Same applies for buildArtifact.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script for generating zksync artifacts only runs in nodejs environment thus 'fs' is used. Exported artifacts have .d.ts and .js extension and are generated directly to dist folder, and have a shape of js object.
2c84dd0
to
b70b8a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5290 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
21d3da3
to
1f19a12
Compare
Description
ZKSync PR 1
This PR introduces ZKSync support for Solidity contracts and restructures build files directory structure.
Drive-by changes
@matterlabs/hardhat-zksync-solc
core-utils/typechain
Related issues
None
Backward compatibility
Yes
Testing
Testing was previously in feat: zksync support PR