fix: browser compatibility checks #5288
Conversation
mshojaei-txfusion
requested review from
yorhodes,
jmrossy,
ltyu,
paulbalaji,
tkporter and
aroralanuk
as code owners
🦋 Changeset detectedLatest commit: ffda2ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… Node.js module restrictions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5288 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
| @@ -1,4 +1,3 @@ | |||
| /* eslint-disable no-restricted-imports */ | |||
There was a problem hiding this comment.
Can we have the rule not apply to test files (which are not bundled I have to assume?)
There was a problem hiding this comment.
Yes I already did this, that is why I removed eslint disable from test files
There was a problem hiding this comment.
Ah yes ofc sorry read it wrong
solidity/eslint.config.mjs
Outdated
| ...MonorepoDefaults, | ||
| { | ||
| ignores: [ | ||
| '**/test/**/*', |
There was a problem hiding this comment.
Why are you ignoring **/test/... why not ./test/**/*?
There was a problem hiding this comment.
fixed, thanks
There was a problem hiding this comment.
I'd rather put these changes in a 1# ZKSync PR, because there we introduce .ts in solidity
| @@ -1,4 +1,3 @@ | |||
| /* eslint-disable no-restricted-imports */ | |||
There was a problem hiding this comment.
Ah yes ofc sorry read it wrong
Description
This PR enhances the ESLint configuration to restrict the usage of Node.js built-in modules across the codebase. This is particularly important for the SDK package which needs to maintain browser compatibility for frontend integrations.
Key changes:
Drive-by changes
Related issues
#5277
Backward compatibility
Yes. These changes only affect development-time linting and do not impact runtime behavior.
Testing
Manual testing: