-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Improve Map performance #2538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge perf improvement, thanks for this!
Very nice. Did you look into how it reacts with a fairly high frequency of change? I mean with pods/events being added, rather than with a static set of resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Yeah it struggles a bit with frequent changes, but that is another issue |
… of nodes or edges Signed-off-by: Oleksandr Dubenko <[email protected]>
Signed-off-by: Oleksandr Dubenko <[email protected]>
Signed-off-by: Oleksandr Dubenko <[email protected]>
Signed-off-by: Oleksandr Dubenko <[email protected]>
Signed-off-by: Oleksandr Dubenko <[email protected]>
Signed-off-by: Oleksandr Dubenko <[email protected]>
Doh. I think I broke the test plugins CI job with the release of the new headlamp-k8s/eslint-config. It is trying to upgrade to the "latest" So you can ignore that test plugins job failure in this PR. |
Got it, thanks for the explanation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This fixes a stack overflow crash #2534 and improves grouping and filtering performance
There's still a bunch of stuff that can be optimized so this is only first step
Testing done:
After fixes:
Map loading time: 5s
Filter by error: <1s
Group by node: <1s
Before:
Map loading time: ~3.5min
Filter by error: 50s
Group by node: 9s