frontend: Fix ReleaseNotes so it works again #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illume
added
bug
|
I noticed there's an air-gap issue related to ReleaseNotes in: So I'll fix that in this PR too. |
illume
force-pushed
the
remove-octokit
branch
3 times, most recently
from
aa8280e to
d554b61
Compare
Fixes #2143 and a CVE with Octokit. Removes Octokit because we just use it to fetch one URL. Signed-off-by: René Dudfield <[email protected]>
If there is an error connecting to the github releases, then it used to be that a message would stay on the screen about fetching release notes... but it would just stay there. Now it disapears after it times out, and then a message is shown that the fetch failed. This message also disapears after 6 seconds. Signed-off-by: René Dudfield <[email protected]>
Signed-off-by: René Dudfield <[email protected]>
The stories didn't show the different states. Also added some documentation for the props fields. Signed-off-by: René Dudfield <[email protected]>
joaquimrocha
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2143 and a CVE with Octokit.
Removes Octokit because we just use it to fetch one URL.
How to test