Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish localising the DateEntry and Calendar #5571

Merged
merged 15 commits into from
Mar 7, 2025
Merged

Finish localising the DateEntry and Calendar #5571

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d3ce4ce
Allow the localisation files to specify the date format and first day…
andydotxyz Mar 2, 2025
b8427ac
Fix the way we convert tags to better support fallbacks
andydotxyz Mar 2, 2025
c7f011d
Move the locale settings out of the translation files.
andydotxyz Mar 5, 2025
617a3a8
add more Sunday-start countries
dweymouth Mar 5, 2025
53c6dd6
Reduce memory usage in map
andydotxyz Mar 6, 2025
ccb3007
change locale map to use struct for settings
dweymouth Mar 7, 2025
416e68b
Update locale_test.go
dweymouth Mar 7, 2025
86b99b0
Resole another test race
andydotxyz Mar 7, 2025
c798137
Add Sweden
andydotxyz Mar 7, 2025
c13ab12
Was not in Go 1.19
andydotxyz Mar 7, 2025
a6d6dd0
Fix test logic to match other menu tests
andydotxyz Mar 7, 2025
382f1ca
Another race
andydotxyz Mar 7, 2025
33a4732
A different attempt to race test issue
andydotxyz Mar 7, 2025
f01eac2
add back two test cases
dweymouth Mar 7, 2025
69f6bb6
more race fixing
andydotxyz Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions widget/locale_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,15 @@ import (
)

func TestGetLocaleWeekStart(t *testing.T) {
assert.Equal(t, "Monday", lookupLocaleSetting(localeWeekStartKey, ""))
assert.Equal(t, "Monday", lookupLocaleSetting(localeWeekStartKey, "en"))
assert.Equal(t, "Monday", lookupLocaleSetting(localeWeekStartKey, "en-GB"))
assert.Equal(t, "Sunday", lookupLocaleSetting(localeWeekStartKey, "en-US"))
assert.Equal(t, "Sunday", lookupLocaleSetting(localeWeekStartKey, "es-US"))
assert.Equal(t, "Monday", lookupLocaleSetting("").weekStartDay.String())
assert.Equal(t, "Monday", lookupLocaleSetting("en").weekStartDay.String())
assert.Equal(t, "Monday", lookupLocaleSetting("en-GB").weekStartDay.String())
assert.Equal(t, "Sunday", lookupLocaleSetting("en-US").weekStartDay.String())
assert.Equal(t, "Sunday", lookupLocaleSetting("es-US").weekStartDay.String())
}

func TestGetLocaleDateFormat(t *testing.T) {
assert.Equal(t, "02/01/2006", lookupLocaleSetting(localeDateFormatKey, ""))
assert.Equal(t, "02/01/2006", lookupLocaleSetting(localeDateFormatKey, "en"))
assert.Equal(t, "02/01/2006", lookupLocaleSetting(localeDateFormatKey, "en-GB"))
assert.Equal(t, "01/02/2006", lookupLocaleSetting(localeDateFormatKey, "en-US"))
assert.Equal(t, "01/02/2006", lookupLocaleSetting(localeDateFormatKey, "es-US"))
assert.Equal(t, "02/01/2006", lookupLocaleSetting("").dateFormat)
assert.Equal(t, "01/02/2006", lookupLocaleSetting("en-US").dateFormat)
assert.Equal(t, "01/02/2006", lookupLocaleSetting("es-US").dateFormat)
}
Loading