Finish localising the DateEntry and Calendar

[andydotxyz]

Fixes #5141

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.

[coveralls]

coverage: 62.322% (+0.01%) from 62.311%
when pulling 69f6bb6 on fix/5141
into 3c25ee0 on develop.

[andydotxyz]

Thanks for adding the Sunday starts - but I don't think they all use US date format ...

[dweymouth]

Thanks for adding the Sunday starts - but I don't think they all use US date format ...

I have them using the day/month/year format?

[andydotxyz]

So you do - I can't read sorry.

[Jacalz]

If you wish to add Swedish to the list then it is Monday and time.DateOnly that is correct.

[andydotxyz]

If you wish to add Swedish to the list then it is Monday and time.DateOnly that is correct.

Thanks for this - but given that Swedish is the language do you mean Sweden? (i.e. (SE)?

This seems like a very memory inefficient data structure with quite a lot of duplicated data.

I have significantly reduced the memory requirement, hopefully this makes it good for now?

[Jacalz]

Thanks for this - but given that Swedish is the language do you mean Sweden? (i.e. (SE)?

Oh, yes of course. That's what I meant

[Jacalz]

I think this might be cleaner to do using strings.Cut.

[andydotxyz]

Doesn't that require the second instance of the separator? It is optional in this instance.

[Jacalz]

I figured it would be possible to do something like this to just use one strings API instead of two to achieve the same result. However, I do see now that the following code assumes that the region is the end of the file so it might be moot.

_, trailing, found := strings.Cut(lang, "-")
if found {
    region = trailing
}

[andydotxyz]

Tests finally passing again

[Jacalz]

Looking good 👍