Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move action lifecycle hooks #12891

Merged
merged 2 commits into from
May 22, 2024
Merged

Move action lifecycle hooks #12891

merged 2 commits into from
May 22, 2024

Conversation

zepfietje
Copy link
Member

Description

This PR moves the action lifecycle hooks so the afterFormValidated and before hooks are called before any relationships are saved in getState().

I have not tested all these action types. Please have a proper look to see if this isn't a breaking change, since you know the actions system better than I do, @danharrin.

Visual changes

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@zepfietje zepfietje added the bug Something isn't working label May 22, 2024
@danharrin danharrin added this to the v3 milestone May 22, 2024
@danharrin danharrin merged commit fe2bc20 into 3.x May 22, 2024
20 checks passed
@danharrin danharrin deleted the move-action-lifecycle-hooks branch May 22, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants