Merge pull request #12891 from filamentphp/move-action-lifecycle-hooks

Move action lifecycle hooks
filamentphp · May 22, 2024 · fe2bc20 · fe2bc20
2 parents dcd1c72 + 00e7c30
commit fe2bc20
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 25 deletions.
diff --git a/packages/actions/src/Concerns/InteractsWithActions.php b/packages/actions/src/Concerns/InteractsWithActions.php
@@ -84,13 +84,17 @@ public function callMountedAction(array $arguments = []): mixed
             if ($this->mountedActionHasForm(mountedAction: $action)) {
                 $action->callBeforeFormValidated();
 
-                $action->formData($form->getState());
-
-                $action->callAfterFormValidated();
+                $action->formData(
+                    $form->getState(afterValidate: function () use ($action) {
+                        $action->callAfterFormValidated();
+
+                        $action->callBefore();
+                    }),
+                );
+            } else {
+                $action->callBefore();
             }
 
-            $action->callBefore();
-
             $result = $action->call([
                 'form' => $form,
             ]);

diff --git a/packages/forms/src/Concerns/HasFormComponentActions.php b/packages/forms/src/Concerns/HasFormComponentActions.php
@@ -65,13 +65,17 @@ public function callMountedFormComponentAction(array $arguments = []): mixed
             if ($this->mountedFormComponentActionHasForm(mountedAction: $action)) {
                 $action->callBeforeFormValidated();
 
-                $action->formData($form->getState());
-
-                $action->callAfterFormValidated();
+                $action->formData(
+                    $form->getState(afterValidate: function () use ($action) {
+                        $action->callAfterFormValidated();
+
+                        $action->callBefore();
+                    }),
+                );
+            } else {
+                $action->callBefore();
             }
 
-            $action->callBefore();
-
             $result = $action->call([
                 'form' => $form,
             ]);

diff --git a/packages/infolists/src/Concerns/InteractsWithInfolists.php b/packages/infolists/src/Concerns/InteractsWithInfolists.php
@@ -109,13 +109,17 @@ public function callMountedInfolistAction(array $arguments = []): mixed
             if ($this->mountedInfolistActionHasForm(mountedAction: $action)) {
                 $action->callBeforeFormValidated();
 
-                $action->formData($form->getState());
-
-                $action->callAfterFormValidated();
+                $action->formData(
+                    $form->getState(afterValidate: function () use ($action) {
+                        $action->callAfterFormValidated();
+
+                        $action->callBefore();
+                    }),
+                );
+            } else {
+                $action->callBefore();
             }
 
-            $action->callBefore();
-
             $result = $action->call([
                 'form' => $form,
             ]);

diff --git a/packages/tables/src/Concerns/HasActions.php b/packages/tables/src/Concerns/HasActions.php
@@ -99,13 +99,17 @@ public function callMountedTableAction(array $arguments = []): mixed
             if ($this->mountedTableActionHasForm(mountedAction: $action)) {
                 $action->callBeforeFormValidated();
 
-                $action->formData($form->getState());
-
-                $action->callAfterFormValidated();
+                $action->formData(
+                    $form->getState(afterValidate: function () use ($action) {
+                        $action->callAfterFormValidated();
+
+                        $action->callBefore();
+                    }),
+                );
+            } else {
+                $action->callBefore();
             }
 
-            $action->callBefore();
-
             $result = $action->call([
                 'form' => $form,
             ]);

diff --git a/packages/tables/src/Concerns/HasBulkActions.php b/packages/tables/src/Concerns/HasBulkActions.php
@@ -70,13 +70,17 @@ public function callMountedTableBulkAction(array $arguments = []): mixed
             if ($this->mountedTableBulkActionHasForm(mountedBulkAction: $action)) {
                 $action->callBeforeFormValidated();
 
-                $action->formData($form->getState());
-
-                $action->callAfterFormValidated();
+                $action->formData(
+                    $form->getState(afterValidate: function () use ($action) {
+                        $action->callAfterFormValidated();
+
+                        $action->callBefore();
+                    }),
+                );
+            } else {
+                $action->callBefore();
             }
 
-            $action->callBefore();
-
             $result = $action->call([
                 'form' => $form,
             ]);