-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(java): Add accept header if endpoint has errors #5848
Merged
ajgateno
merged 7 commits into
main
from
alberto/add-accept-header-if-endpoint-has-errors
Feb 3, 2025
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4f82a63
fix(java): Add accept header if endpoint has errors
68731bb
Write and run test
ae80235
update snippets
6271d1d
Merge branch 'main' into alberto/add-accept-header-if-endpoint-has-er…
fcab3fa
Add versions entry
1b453e7
Run seed
1081703
Merge branch 'main' into alberto/add-accept-header-if-endpoint-has-er…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
...tion/ir-generator-tests/src/dynamic-snippets/__test__/test-definitions/accept-header.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| { | ||
| "version": "1.0.0", | ||
| "types": {}, | ||
| "headers": [], | ||
| "endpoints": { | ||
| "endpoint_service.endpoint": { | ||
| "auth": { | ||
| "type": "bearer", | ||
| "token": { | ||
| "originalName": "token", | ||
| "camelCase": { | ||
| "unsafeName": "token", | ||
| "safeName": "token" | ||
| }, | ||
| "snakeCase": { | ||
| "unsafeName": "token", | ||
| "safeName": "token" | ||
| }, | ||
| "screamingSnakeCase": { | ||
| "unsafeName": "TOKEN", | ||
| "safeName": "TOKEN" | ||
| }, | ||
| "pascalCase": { | ||
| "unsafeName": "Token", | ||
| "safeName": "Token" | ||
| } | ||
| } | ||
| }, | ||
| "declaration": { | ||
| "name": { | ||
| "originalName": "endpoint", | ||
| "camelCase": { | ||
| "unsafeName": "endpoint", | ||
| "safeName": "endpoint" | ||
| }, | ||
| "snakeCase": { | ||
| "unsafeName": "endpoint", | ||
| "safeName": "endpoint" | ||
| }, | ||
| "screamingSnakeCase": { | ||
| "unsafeName": "ENDPOINT", | ||
| "safeName": "ENDPOINT" | ||
| }, | ||
| "pascalCase": { | ||
| "unsafeName": "Endpoint", | ||
| "safeName": "Endpoint" | ||
| } | ||
| }, | ||
| "fernFilepath": { | ||
| "allParts": [ | ||
| { | ||
| "originalName": "service", | ||
| "camelCase": { | ||
| "unsafeName": "service", | ||
| "safeName": "service" | ||
| }, | ||
| "snakeCase": { | ||
| "unsafeName": "service", | ||
| "safeName": "service" | ||
| }, | ||
| "screamingSnakeCase": { | ||
| "unsafeName": "SERVICE", | ||
| "safeName": "SERVICE" | ||
| }, | ||
| "pascalCase": { | ||
| "unsafeName": "Service", | ||
| "safeName": "Service" | ||
| } | ||
| } | ||
| ], | ||
| "packagePath": [], | ||
| "file": { | ||
| "originalName": "service", | ||
| "camelCase": { | ||
| "unsafeName": "service", | ||
| "safeName": "service" | ||
| }, | ||
| "snakeCase": { | ||
| "unsafeName": "service", | ||
| "safeName": "service" | ||
| }, | ||
| "screamingSnakeCase": { | ||
| "unsafeName": "SERVICE", | ||
| "safeName": "SERVICE" | ||
| }, | ||
| "pascalCase": { | ||
| "unsafeName": "Service", | ||
| "safeName": "Service" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "location": { | ||
| "method": "DELETE", | ||
| "path": "/container/" | ||
| }, | ||
| "request": { | ||
| "type": "body", | ||
| "pathParameters": [], | ||
| "body": null | ||
| }, | ||
| "response": { | ||
| "type": "json" | ||
| } | ||
| } | ||
| }, | ||
| "environments": null | ||
| } |
76 changes: 76 additions & 0 deletions
76
packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/accept-header.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| { | ||
| "types": {}, | ||
| "subpackages": { | ||
| "subpackage_service": { | ||
| "subpackageId": "subpackage_service", | ||
| "name": "service", | ||
| "endpoints": [ | ||
| { | ||
| "auth": true, | ||
| "method": "DELETE", | ||
| "id": "endpoint", | ||
| "originalEndpointId": "endpoint_service.endpoint", | ||
| "name": "Endpoint", | ||
| "path": { | ||
| "pathParameters": [], | ||
| "parts": [ | ||
| { | ||
| "type": "literal", | ||
| "value": "/container" | ||
| }, | ||
| { | ||
| "type": "literal", | ||
| "value": "/" | ||
| } | ||
| ] | ||
| }, | ||
| "queryParameters": [], | ||
| "headers": [], | ||
| "errorsV2": [ | ||
| { | ||
| "type": { | ||
| "type": "alias", | ||
| "value": { | ||
| "type": "unknown" | ||
| } | ||
| }, | ||
| "statusCode": 404, | ||
| "description": "Admin not found", | ||
| "name": "NotFoundError", | ||
| "examples": [] | ||
| } | ||
| ], | ||
| "examples": [ | ||
| { | ||
| "path": "/container/", | ||
| "pathParameters": {}, | ||
| "queryParameters": {}, | ||
| "headers": {}, | ||
| "responseStatusCode": 204, | ||
| "codeSamples": [] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "webhooks": [], | ||
| "websockets": [], | ||
| "types": [], | ||
| "subpackages": [] | ||
| } | ||
| }, | ||
| "rootPackage": { | ||
| "endpoints": [], | ||
| "webhooks": [], | ||
| "websockets": [], | ||
| "types": [], | ||
| "subpackages": [ | ||
| "subpackage_service" | ||
| ] | ||
| }, | ||
| "auth": { | ||
| "type": "bearerAuth", | ||
| "tokenName": "token" | ||
| }, | ||
| "snippetsConfiguration": {}, | ||
| "globalHeaders": [] | ||
| } |
61 changes: 61 additions & 0 deletions
61
seed/java-sdk/accept-header/accept-header/.github/workflows/ci.yml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
4 changes: 4 additions & 0 deletions
4
seed/java-sdk/accept-header/accept-header/.mock/definition/api.yml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
16 changes: 16 additions & 0 deletions
16
seed/java-sdk/accept-header/accept-header/.mock/definition/service.yml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline - we can actually model this in a way where the
httpEndpointhas anacceptproperty that represents the set ofAcceptheader values that should be sent in the request. Same idea that you're capturing here, just slightly different implementation.