fix(java): Add accept header if endpoint has errors #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgateno
commented
Feb 3, 2025
| .url(httpUrl) | ||
| .method("DELETE", null) | ||
| .headers(Headers.of(clientOptions.headers(requestOptions))) | ||
| .addHeader("Accept", "application/json") |
amckinney
approved these changes
Feb 3, 2025
|
|
||
| Set<String> contentTypes = new HashSet<>(); | ||
|
|
||
| // TODO: We'll need to get error content types from the IR once they're available. |
There was a problem hiding this comment.
Discussed offline - we can actually model this in a way where the httpEndpoint has an accept property that represents the set of Accept header values that should be sent in the request. Same idea that you're capturing here, just slightly different implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an endpoint has errors, we need to pass in an accept header for application/json. In the future we'll want to delegate determining the content type to the IR but for now it's okay to have this here to get around customer issues.