Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: blog: Zephyr memory layout update #356

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

marekmatej
Copy link
Collaborator

Update the pictures to illustrate the memory utilization for a default scenario with a single CPU as well as a multi-processor case.

@pedrominatel pedrominatel added the needs review Needs someone to be assigned to review label Dec 10, 2024
@marekmatej marekmatej force-pushed the bugfix/esp32_bootstrapping2 branch 4 times, most recently from 815a22d to e229e94 Compare December 11, 2024 13:44
Copy link

🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr356/

@marekmatej marekmatej force-pushed the bugfix/esp32_bootstrapping2 branch from e229e94 to 3b1eda0 Compare December 12, 2024 15:48
Copy link

🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr356/

@marekmatej
Copy link
Collaborator Author

@pedrominatel @f-hollow Guys, can you take a look? You are the only available reviewers for the articles.

@f-hollow
Copy link
Collaborator

@marekmatej Sorry for the delay.

I seem to have fixed the issue with unrelated broken links in CI once and for all, please rebase your branch on upstream/main and see if the job Check links in diffs passes.

I will do the review right now.

Copy link
Collaborator

@f-hollow f-hollow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marekmatej Thank you for further improving the article!

I only have a few nitpicks.

content/blog/esp32-bootstrapping/index.md Outdated Show resolved Hide resolved
content/blog/esp32-bootstrapping/index.md Outdated Show resolved Hide resolved
content/blog/esp32-bootstrapping/index.md Outdated Show resolved Hide resolved
content/blog/esp32-bootstrapping/index.md Outdated Show resolved Hide resolved
content/blog/esp32-bootstrapping/index.md Outdated Show resolved Hide resolved
content/blog/esp32-bootstrapping/index.md Outdated Show resolved Hide resolved
content/blog/esp32-bootstrapping/index.md Outdated Show resolved Hide resolved
content/blog/esp32-bootstrapping/index.md Show resolved Hide resolved
content/blog/esp32-bootstrapping/index.md Outdated Show resolved Hide resolved
content/blog/esp32-bootstrapping/index.md Outdated Show resolved Hide resolved
@marekmatej marekmatej force-pushed the bugfix/esp32_bootstrapping2 branch from 3b1eda0 to b7860c3 Compare December 17, 2024 10:32
Copy link

🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr356/

Copy link
Collaborator

@f-hollow f-hollow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget to implement this carefully hidden comment and check another new suggstion.

Otherwise, LGTM!

The Zephyr sample code (`samples/drivers/ipm/ipm_esp32`) uses IPM (Inter-Processor Mailbox) to demonstrate a simple two-way communication between the `PRO_CPU` core and `APP_CPU` core. Images for both CPU cores must be loaded using the MCUboot.
Note that there is no support for running AMP if the Simple Boot mechanism is used.

Building and flashing a complete set of images running the IPM sample:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this:

Suggested change
Building and flashing a complete set of images running the IPM sample:
Now we can build and flash a complete set of images running the IPM sample:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! fixed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @f-hollow, I've fixed all remaining findings.

Multiple updates and fixes:

- Add memory layouts for AMP scenarios
- Fix typos and errors in diagrams
- Fix typos and errors in text
- Remove unused file

Signed-off-by: Marek Matej <[email protected]>
@marekmatej marekmatej force-pushed the bugfix/esp32_bootstrapping2 branch from b7860c3 to 2bc5f56 Compare December 17, 2024 13:01
Copy link

🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr356/

@f-hollow f-hollow merged commit 6601f2b into espressif:main Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Needs someone to be assigned to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants