-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content: blog: Zephyr memory layout update #356
content: blog: Zephyr memory layout update #356
Conversation
815a22d
to
e229e94
Compare
🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr356/ |
e229e94
to
3b1eda0
Compare
🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr356/ |
@pedrominatel @f-hollow Guys, can you take a look? You are the only available reviewers for the articles. |
@marekmatej Sorry for the delay. I seem to have fixed the issue with unrelated broken links in CI once and for all, please rebase your branch on I will do the review right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marekmatej Thank you for further improving the article!
I only have a few nitpicks.
3b1eda0
to
b7860c3
Compare
🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr356/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to implement this carefully hidden comment and check another new suggstion.
Otherwise, LGTM!
The Zephyr sample code (`samples/drivers/ipm/ipm_esp32`) uses IPM (Inter-Processor Mailbox) to demonstrate a simple two-way communication between the `PRO_CPU` core and `APP_CPU` core. Images for both CPU cores must be loaded using the MCUboot. | ||
Note that there is no support for running AMP if the Simple Boot mechanism is used. | ||
|
||
Building and flashing a complete set of images running the IPM sample: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this:
Building and flashing a complete set of images running the IPM sample: | |
Now we can build and flash a complete set of images running the IPM sample: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx! fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @f-hollow, I've fixed all remaining findings.
Multiple updates and fixes: - Add memory layouts for AMP scenarios - Fix typos and errors in diagrams - Fix typos and errors in text - Remove unused file Signed-off-by: Marek Matej <[email protected]>
b7860c3
to
2bc5f56
Compare
🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr356/ |
Update the pictures to illustrate the memory utilization for a default scenario with a single CPU as well as a multi-processor case.