Ci/change pr check links target branch #366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
pr-check-links
has a notion of a base-commit. This is a commit at which the feature branch was forked. This commit is determined using thegit merge-base
command. After that, the changes in all subsequent commits are checked bypr-check-links
.On numerous occasions (the latest one is #356 and the related job), the contributors rebased their feature branch directly against upstream while their fork
origin/main
branch stayed outdated. Due to this, the base commit was determined incorrectly, which resulted in checking links unrelated to the changes in the pull request.This PR changes the branch against which the base commit is determined from hard-coded
origin/main
to the branch defined by the CI environment variablesTARGET_REPO_URL
andTARGET_BRANCH
. These variables are set to theupstream/main
branch.Related
Testing
Testing was done in this testing environment.
Checklist
Before submitting a Pull Request, please ensure the following: