Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/change pr check links target branch #366

Merged

Conversation

f-hollow
Copy link
Collaborator

@f-hollow f-hollow commented Dec 17, 2024

Description

The pr-check-links has a notion of a base-commit. This is a commit at which the feature branch was forked. This commit is determined using the git merge-base command. After that, the changes in all subsequent commits are checked by pr-check-links.

On numerous occasions (the latest one is #356 and the related job), the contributors rebased their feature branch directly against upstream while their fork origin/main branch stayed outdated. Due to this, the base commit was determined incorrectly, which resulted in checking links unrelated to the changes in the pull request.

This PR changes the branch against which the base commit is determined from hard-coded origin/main to the branch defined by the CI environment variables TARGET_REPO_URL and TARGET_BRANCH. These variables are set to the upstream/main branch.

Related

Testing

Testing was done in this testing environment.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@f-hollow f-hollow force-pushed the ci/change-pr-check-links-target-branch branch from a8863af to a773570 Compare December 17, 2024 06:26
Copy link

🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr366/

Copy link

🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr366/

@f-hollow f-hollow force-pushed the ci/change-pr-check-links-target-branch branch from a773570 to 4bf0081 Compare December 17, 2024 06:30
Copy link

🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr366/

@f-hollow f-hollow merged commit 71c76cd into espressif:main Dec 17, 2024
4 checks passed
@f-hollow f-hollow deleted the ci/change-pr-check-links-target-branch branch December 17, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant