Skip to content

Commit

Permalink
added RAILS_RELATIVE_URL_ROOT support
Browse files Browse the repository at this point in the history
  • Loading branch information
frohoff committed Dec 28, 2012
1 parent e9394c4 commit 21e55ca
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 7 deletions.
1 change: 1 addition & 0 deletions app/mailers/notify.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ class Notify < ActionMailer::Base
default_url_options[:host] = Gitlab.config.gitlab.host
default_url_options[:protocol] = Gitlab.config.gitlab.protocol
default_url_options[:port] = Gitlab.config.gitlab.port if Gitlab.config.gitlab_on_non_standard_port?
default_url_options[:script_name] = Gitlab.config.gitlab.relative_url_root

default from: Gitlab.config.gitlab.email_from

Expand Down
5 changes: 4 additions & 1 deletion config.ru
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# This file is used by Rack-based servers to start the application.

require ::File.expand_path('../config/environment', __FILE__)
run Gitlab::Application

map ENV['RAILS_RELATIVE_URL_ROOT'] || "/" do
run Gitlab::Application
end
3 changes: 3 additions & 0 deletions config/gitlab.yml.example
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ gitlab:
host: localhost
port: 80
https: false
# uncomment and customize to run in non-root path
# note that ENV['RAILS_RELATIVE_URL_ROOT'] in config/unicorn.rb may need to be changed
# relative_url_root: /gitlab

## Email settings
# Email address used in the "From" field in mails sent by GitLab
Expand Down
4 changes: 3 additions & 1 deletion config/initializers/1_settings.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ def build_gitlab_url
[ gitlab.protocol,
"://",
gitlab.host,
custom_port
custom_port,
gitlab.relative_url_root
].join('')
end
end
Expand All @@ -45,6 +46,7 @@ def build_gitlab_url
Settings.gitlab['host'] ||= 'localhost'
Settings.gitlab['https'] ||= false
Settings.gitlab['port'] ||= Settings.gitlab.https ? 443 : 80
Settings.gitlab['relative_url_root'] ||= ''
Settings.gitlab['protocol'] ||= Settings.gitlab.https ? "https" : "http"
Settings.gitlab['email_from'] ||= "gitlab@#{Settings.gitlab.host}"
Settings.gitlab['url'] ||= Settings.send(:build_gitlab_url)
Expand Down
2 changes: 1 addition & 1 deletion config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
project_root: Gitlab.config.gitolite.repos_path,
upload_pack: Gitlab.config.gitolite.upload_pack,
receive_pack: Gitlab.config.gitolite.receive_pack
}), at: '/:path', constraints: { path: /[-\/\w\.-]+\.git/ }
}), at: '/', constraints: lambda { |request| /[-\/\w\.-]+\.git/.match(request.path_info) }

#
# Help
Expand Down
4 changes: 4 additions & 0 deletions config/unicorn.rb.example
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# uncomment and customize to run in non-root path
# note that config/gitlab.yml web path should also be changed
# ENV['RAILS_RELATIVE_URL_ROOT'] = "/gitlab"

app_dir = "/home/gitlab/gitlab/"
worker_processes 2
working_directory app_dir
Expand Down
4 changes: 0 additions & 4 deletions lib/gitlab/backend/grack_auth.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ def valid?
# Pass Gitolite update hook
ENV['GL_BYPASS_UPDATE_HOOK'] = "true"

# Need this patch due to the rails mount
@env['PATH_INFO'] = @request.path
@env['SCRIPT_NAME'] = ""

# Find project by PATH_INFO from env
if m = /^\/([\w\.\/-]+)\.git/.match(@request.path_info).to_a
self.project = Project.find_with_namespace(m.last)
Expand Down

0 comments on commit 21e55ca

Please sign in to comment.