Fix dir_exists?

dyarnell · Dec 28, 2012 · e9394c4 · e9394c4
1 parent d03964d
commit e9394c4
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/app/models/namespace.rb b/app/models/namespace.rb
@@ -51,12 +51,17 @@ def human_name
   end
 
   def ensure_dir_exist
-    dir_exists? || system("mkdir -m 770 #{namespace_dir_path}")
+    unless dir_exists?
+      system("mkdir -m 770 #{namespace_full_path}")
+    end
   end
 
   def dir_exists?
-    namespace_dir_path = File.join(Gitlab.config.gitolite.repos_path, path)
-    File.exists?(namespace_dir_path)
+    File.exists?(namespace_full_path)
+  end
+
+  def namespace_full_path
+    @namespace_full_path ||= File.join(Gitlab.config.gitolite.repos_path, path)
   end
 
   def move_dir