Custom item validator per folder #617
Conversation
|
@lbiaggi I've had a quick look and it looks very useful! I will do a deeper review and some testing as soon as possible. |
Ok! |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #617 +/- ##
========================================
Coverage 96.15% 96.16%
========================================
Files 41 41
Lines 5173 5185 +12
Branches 1214 1217 +3
========================================
+ Hits 4974 4986 +12
+ Misses 127 126 -1
- Partials 72 73 +1 ☔ View full report in Codecov by Sentry. |
lbiaggi
force-pushed
the
extensions
branch
4 times, most recently
from
b1f479c to
f0ca9d2
Compare
|
Can you re-review @neerdoc? I've inserted tests, updated the sample reqs project and documentation. |
lbiaggi
force-pushed
the
extensions
branch
12 times, most recently
from
5fef8cb to
b5651a6
Compare
There was a problem hiding this comment.
I've had another look and as far as I can see this is a nice improvement.
It is a rather big change (lot's of new code, I like it!) so I would like to test it a bit more on my own system before we merge it, but good work @lbiaggi!
@jacebrowning should also have a look at it.
|
@neerdoc no worries, I understand. How can I propose more drastic changes? (I'm looking to improve and expand references type to be more generic and customizable, e.g., to support external links from another repo.) or at least an interface to create custom references. |
I would suggest that you first read through all open issues to get a good grasp of what other peoples' opinions are regarding where the software is going. Jump in to whatever discussions there already are and voice you suggestions. If you have new ideas, just open an issue on the subject and we will have a discussion about it! |
|
Should I rebase and fix the conflict? |
|
Yes please, that would be very helpful! |
lbiaggi
force-pushed
the
extensions
branch
2 times, most recently
from
2e45de0 to
c8cb011
Compare
|
Done, if a conflict appears, and I did not update the PR, please ping me |
|
Friendly ping reminder @jacebrowning |
|
@lbiaggi sorry, I haven't had a chance to look at this until now. I think we should stick to one feature per pull request (and corresponding issue for discussion, if applicable). Since there are three distinct features here, I'd like to see this split up into three separate pull requests that can be reviewed and applied independently. |
|
OK, but bear in mind that I rely on the first one to do the other two Can I signalize they are dependent? (at least from the first) |
|
Yeah, you can identify that they are dependent or just open the base pull request first. |
lbiaggi
force-pushed
the
extensions
branch
3 times, most recently
from
adf2b2d to
f34b6a1
Compare
lbiaggi
changed the title
|
@jacebrowning done |
lbiaggi
changed the title
|
@jacebrowning ping |
|
@lbiaggi this pull request still seems to contain multiple features: custom item validation and something about changing the SHA that I don't fully understand. I'd like to see this split into two separate pull requests for further review. Thanks! |
Sorry, IMO they were the same feature because without the SHA, custom validator doesn't seem to be doing something interesting. I'm not changing the SHA, I'm just calculating the SHA for each file reference... I will do it now. |
lbiaggi
changed the title
|
@jacebrowning done, sorry for misinterpreting what you meant |
Hi @jacebrowning, we have been using doorstop to manage our ISO 26262 requirements, it is part of our core workflow.
We have improved certain areas of the software to match our requirements, and we think it would be useful to share with upstream these changes.
.doorstop.ymlto enable them (we called them extension, as we intend to add more features if necessary)- Where we can define a custom validator for the items from a specific folder
- If file references from this folder should calculate the SHA-256 for them (During review / validate without
-W)- Change the buffer size for when doing the SHA
We made these changes because we didn't want to override most of the default behaviour from doorstop, and yet we wanted to be able to tweak certain validations for specific items.