Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate sha for files in reference #645

Merged
merged 9 commits into from
Apr 4, 2024

Conversation

lbiaggi
Copy link
Contributor

@lbiaggi lbiaggi commented Mar 21, 2024

It introduces a way to let doorstop do the SHA for the files in references.

This depends on: #617 only because it creates the test file.

Closes #564+s.

@lbiaggi lbiaggi force-pushed the calculate_sha_refs branch 4 times, most recently from 23309dd to 69520c9 Compare March 21, 2024 03:35
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 96.24%. Comparing base (b94019a) to head (31e3ad8).
Report is 2 commits behind head on develop.

Files Patch % Lines
doorstop/core/item.py 85.71% 4 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #645      +/-   ##
===========================================
+ Coverage    96.15%   96.24%   +0.09%     
===========================================
  Files           41       41              
  Lines         5173     5220      +47     
  Branches      1214     1226      +12     
===========================================
+ Hits          4974     5024      +50     
+ Misses         127      124       -3     
  Partials        72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbiaggi lbiaggi force-pushed the calculate_sha_refs branch from 69520c9 to 31e3ad8 Compare March 21, 2024 03:47
@lbiaggi
Copy link
Contributor Author

lbiaggi commented Apr 4, 2024

ping @jacebrowning

Copy link
Member

@jacebrowning jacebrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Thanks!

@jacebrowning jacebrowning merged commit 7537688 into doorstop-dev:develop Apr 4, 2024
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Discussion: hash based review of external reference content
3 participants