Boll Rolling on Disc docstrings as per #348 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason the thumbnail does not spin anymore? |
Yes, to be expected. |
|
This PR broke the animation thumbnail which causes it not to show in the gallery and not to show in the README (and thus front page of the documentation). |
moorepants
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstrings as per #348
In this case
backend = 'numpy'slowed down forming the problem. As the eoms have over 300,000 operations, maybe to be expected?Could not reduce fps in the animation without making the video 'jumpy'.
Added solution, but this did not really help the speed much, at least not on my PC