Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-eslint): parse rule names containing slashes correctly #895

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

matejchalk
Copy link
Collaborator

@matejchalk matejchalk commented Dec 17, 2024

Some rules from eslint-plugin-n weren't being discovered correctly, was being logged as warning:

image

This is because for rule IDs like n/prefer-promises/fs the parser incorrectly identified which part was the plugin name.

Now that the parsing was adjusted, the warnings are gone.

@matejchalk matejchalk added the 🐛 bug something isn't working label Dec 17, 2024
Copy link

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit f570c58 with source commit 284f755.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Performance 🟡 54 🔴 47 ↓ −6.4
Code coverage 🟢 91 🟢 91 ↑ +0.1
Security 🟡 81 🟡 81
Updates 🟡 80 🟡 80
Accessibility 🟢 91 🟢 91
Best Practices 🟢 100 🟢 100
SEO 🟡 61 🟡 61
Bug prevention 🟢 100 🟢 100
Code style 🟢 100 🟢 100
👍 1 group improved, 👎 1 group regressed, 👍 2 audits improved, 👎 3 audits regressed, 13 audits changed without impacting score

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Lighthouse Performance 🟡 54 🔴 47 ↓ −6.4
Code coverage Code coverage metrics 🟢 91 🟢 91 ↑ +0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Lighthouse Largest Contentful Paint 🟨 3.1 s 🟨 3.7 s ↑ +19.5 %
Lighthouse First Contentful Paint 🟨 2.8 s 🟥 3.2 s ↑ +13.3 %
Lighthouse Speed Index 🟥 6.4 s 🟥 7.1 s ↑ +10.1 %
Lighthouse Time to Interactive 🟥 16.6 s 🟥 14.7 s ↓ −11.3 %
Code coverage Branch coverage 🟨 85.7 % 🟨 85.8 % ↑ +0.1 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 1,818 KiB 🟩 Total size was 1,831 KiB ↑ +0.7 %
Lighthouse Minimizes main-thread work 🟥 23.0 s 🟥 18.8 s ↓ −18.4 %
Lighthouse Total Blocking Time 🟥 10,290 ms 🟥 6,170 ms ↓ −40.1 %
Lighthouse Metrics 🟩 100% 🟩 100% ↓ −11.3 %
Lighthouse JavaScript execution time 🟥 9.0 s 🟥 8.2 s ↓ −8.3 %
Lighthouse Max Potential First Input Delay 🟥 3,410 ms 🟥 2,820 ms ↓ −17.3 %
Lighthouse Uses efficient cache policy on static assets 🟨 28 resources found 🟨 28 resources found ↑ +0.1 %
Lighthouse Eliminate render-blocking resources 🟥 Potential savings of 1,020 ms 🟥 Potential savings of 1,240 ms ↑ +21 %
Lighthouse Initial server response time was short 🟩 Root document took 400 ms 🟩 Root document took 490 ms ↑ +20.7 %
Lighthouse Server Backend Latencies 🟩 160 ms 🟩 120 ms ↓ −23.9 %
Lighthouse Reduce unused CSS 🟥 Potential savings of 67 KiB 🟥 Potential savings of 67 KiB ↓ −3.2 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 20 ms ↓ −3.9 %
Code coverage Line coverage 🟩 90.9 % 🟩 90.9 % ↑ +0.1 %

567 other audits are unchanged.

@matejchalk matejchalk merged commit f1163d0 into main Dec 17, 2024
18 checks passed
@matejchalk matejchalk deleted the fix-node-lint-rules branch December 17, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug something isn't working 🧩 eslint-plugin 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants