fix(plugin-eslint): parse rule names containing slashes correctly

code-pushup · Dec 17, 2024 · f1163d0 · f1163d0
1 parent 9d6eacf
commit f1163d0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/plugin-eslint/src/lib/meta/parse.ts b/packages/plugin-eslint/src/lib/meta/parse.ts
@@ -8,7 +8,9 @@ export type RuleData = {
 };
 
 export function parseRuleId(ruleId: string): { plugin?: string; name: string } {
-  const i = ruleId.lastIndexOf('/');
+  const i = ruleId.startsWith('@')
+    ? ruleId.lastIndexOf('/')
+    : ruleId.indexOf('/');
   if (i === -1) {
     return { name: ruleId };
   }

diff --git a/packages/plugin-eslint/src/lib/meta/parse.unit.test.ts b/packages/plugin-eslint/src/lib/meta/parse.unit.test.ts
@@ -32,6 +32,11 @@ describe('parseRuleId', () => {
       plugin: '@angular-eslint/template',
       name: 'no-negated-async',
     },
+    {
+      ruleId: 'n/prefer-promises/fs',
+      plugin: 'n',
+      name: 'prefer-promises/fs',
+    },
   ])('$ruleId => name: $name, plugin: $plugin', ({ ruleId, name, plugin }) => {
     expect(parseRuleId(ruleId)).toEqual({ name, plugin });
   });