remove dependence on and references to db docker definition in delphi/operations repo
#1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also some documentation updates we havent needed `dev/docker/database/Dockerfile` from `delphi/operations` since the v4 merge, which moved to building on a Percona container
…delphi/operations repo
melange396
added
documentation
dependencies
dshemetov
previously approved these changes
Oct 10, 2022
| @@ -78,7 +78,7 @@ web: | |||
| @# Build the web_epidata image | |||
| @cd repos/delphi/delphi-epidata;\ | |||
| docker build -t delphi_web_epidata -f ./devops/Dockerfile .;\ | |||
| cd ../../../ | |||
| cd - | |||
There was a problem hiding this comment.
til: lifehack! productivity +100% 👍
|
tag #965 |
|
nice, didnt realize you had that issue open regarding the |
also some documentation updates we havent needed `dev/docker/database/Dockerfile` from `delphi/operations` since the v4 merge, which moved to building on a Percona container
…delphi/operations repo
…/delphi-epidata into rm_operations_database_docker
|
ugh, i made a mess of the commit history, but this should now be against the |
2 tasks
Closed
dshemetov
previously approved these changes
Oct 10, 2022
|
you can rebase, clean, and force push, if you want. i didn't check this PR locally |
|
whoops, i let this languish for a month and a half, gonna merge now |
|
...or rather, i will merge when i get another approval |
|
this also furthers the goals of #965 |
dshemetov
approved these changes
Dec 6, 2022
|
fwiw, when i fixed the merge conflicts on this, i went with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delphi_databasefromci.yamland devMakefiledev/docker/python/Dockerfilewith a reference to its dependency ondelphi/operationsrepositorywe havent needed
dev/docker/database/Dockerfilefromdelphi/operations(or thedelphi_databaseimage it builds) since the v4 merge, which moved to building on a Percona container.