Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vestiges of PHP #1001

Closed
melange396 opened this issue Oct 10, 2022 · 1 comment · Fixed by #1092
Closed

Remove vestiges of PHP #1001

melange396 opened this issue Oct 10, 2022 · 1 comment · Fixed by #1092
Assignees
Labels
chore code health readability, maintainability, best practices, etc dependencies Pull requests that update a dependency file documentation good first issue help wanted

Comments

@melange396
Copy link
Collaborator

Remove the PHP files that are no longer in use, as well as other associated files.

This is not to be confused with the "php" alias endpoint, which exists for backwards compatibility reasons and should not be removed. It is often referred to as 'http://delphi_web_epidata/epidata/api.php' or 'https://delphi.cmu.edu/epidata/api.php' or simply even /api.php in the source code.

  • The files ./src/server/*.php are part of an older version of the API web server and have since been superseded.

  • The files ./src/acquisition/*/*.php should probably go too, but i am unsure of their function.

  • Some dev guide documentation still includes references to PHP files and services which should be updated (found locally in ./docs/epidata_development.md along with similar files in the operations repository)

  • The files in ./dev/docker/web/* help define a docker image to run the old PHP service (it builds upon the base image definition in the operations repo, found here). The ./dev/docker/web/ directory can be removed, or it can be emptied and the docker definition from ./devops/* could be relocated there. This is related to [[remove dependence on and references to db docker definition in delphi/operations repo #1000]] and [[Get "secrets" from something other than the operations repo #965]]

@melange396 melange396 added documentation dependencies Pull requests that update a dependency file code health readability, maintainability, best practices, etc labels Oct 10, 2022
@BrainIsDead
Copy link
Contributor

@melange396 there are cdc_upload.php, dasboard.php and master.php in ./src/acquisition/*/*:

  • cdc_upload.php meets once in /delphi-epidata/deploy.json
  • dashboard.php should be available by the link https://delphi.cmu.edu/~automation/public/wiki/ but it returns 404 for me, also meets in /delphi-epidata/deploy.json
  • master.php is for rearing wiki_raw table independently and in parallel to wiki_download.py, and looks loke exists in wiki_download as MASTER_URL = 'https://delphi.cmu.edu/~automation/public/wiki/master.php' (but link returns 404 for me). Also meets in /delphi-epidata/deploy.json

Not sure what I should to do with these files

@BrainIsDead BrainIsDead linked a pull request Feb 22, 2023 that will close this issue
@BrainIsDead BrainIsDead self-assigned this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore code health readability, maintainability, best practices, etc dependencies Pull requests that update a dependency file documentation good first issue help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants