Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder and update metadata docstring, convert last_update field to datetime #118

Merged
merged 5 commits into from
Oct 30, 2020

Conversation

chinandrew
Copy link
Collaborator

@chinandrew chinandrew commented Oct 8, 2020

Closes #109

Summary of changes:

  • Reorder values in docstring to align with actual returned values
  • Add documentation for columns that weren't previously included.

TODO:

  • convert timestamp for last updated to datetime instead of unix time.

┆Issue is synchronized with this Asana task by Unito

@capnrefsmmat
Copy link
Contributor

There's an incoming new column that may get added soon: cmu-delphi/delphi-epidata#236

But otherwise I like this change.

@chinandrew chinandrew changed the title Reorder and update metadata docstring Reorder and update metadata docstring, convert last_update field to datetime Oct 9, 2020
@capnrefsmmat
Copy link
Contributor

Merge conflict now, but I think this is good to merge when fixed (unless we want to wait for cmu-delphi/delphi-epidata#236)

@chinandrew
Copy link
Collaborator Author

Merge conflict now, but I think this is good to merge when fixed (unless we want to wait for cmu-delphi/delphi-epidata#236)

Thanks, conflict resolved. I don't have a good sense of timeline for when that linked pr will be merged, but figure it's good to keep things as correct as possible and change later if things change (even if we never actually publish new docs publicly).

@capnrefsmmat capnrefsmmat merged commit 6a14baa into main Oct 30, 2020
@chinandrew chinandrew deleted the update-metadata-docstring branch October 30, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update covidcast.metadata() return values in docstring
2 participants