Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update covidcast.metadata() return values in docstring #109

Closed
chinandrew opened this issue Oct 6, 2020 · 3 comments · Fixed by #118
Closed

Update covidcast.metadata() return values in docstring #109

chinandrew opened this issue Oct 6, 2020 · 3 comments · Fixed by #118

Comments

@chinandrew
Copy link
Collaborator

chinandrew commented Oct 6, 2020

Currently the docstring is missing a few columns which get returned, and is also out of order

documented:
data_source signal min_time max_time geo_type time_type num_locations min_value max_value mean_value stdev_value

returned (with example row:

        data_source                 signal time_type geo_type   min_time   max_time  num_locations  min_value  max_value  mean_value  stdev_value  last_update  max_issue  min_lag  max_lag
0     doctor-visits       smoothed_adj_cli       day   county 2020-02-01 2020-10-01           2514    0.00000  87.670832    2.674555     3.358741   1601853923   20201004        2      129

capnrefsmmat I'm not actually sure what those last 4 undocumented columns mean, is there a reference somewhere? Is the last updated in unix time, and if so, is that intentional? (1601853923 = Oct 4)

┆Issue is synchronized with this Asana task by Unito

@chinandrew chinandrew changed the title Update covidcast.signal() docstring Update covidcast.metadata() return values in docstring Oct 6, 2020
@chinandrew
Copy link
Collaborator Author

I think I found the answers here

Should we convert the unix time to a date[time] object?

@capnrefsmmat
Copy link
Contributor

Yeah, I think that'd be helpful. It's unfortunate that a Unix timestamp crept into the metadata, so let's convert it to a datetime.

@chinandrew
Copy link
Collaborator Author

👍 Done in #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants