-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database object for the HCAL negative energy filter #8447
Database object for the HCAL negative energy filter #8447
Conversation
A new Pull Request was created by @igv4321 for CMSSW_7_5_X. Database object for the HCAL negative energy filter It involves the following packages: CondCore/HcalPlugins @diguida, @cerminar, @cmsbuild, @nclopezo, @ggovi, @mmusich can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
-1 you can see the results of the tests here: |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @nclopezo, @ktf, @smuzaffar |
+1 |
Database object for the HCAL negative energy filter
Database object for the HCAL negative energy filter. Current filter relies on "Method 1" OOT pileup subtraction which is no longer being used. This object will allow us to remove dependence on "Method 1".
Once this code gets in and the relevant tag gets into the relval GT, the HCAL reco code will be modified to use it.