-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of the HCAL negative energy filter code #9137
Conversation
A new Pull Request was created by @igv4321 for CMSSW_7_4_X. Backport of the HCAL negative energy filter code It involves the following packages: CondCore/HcalPlugins @nclopezo, @cvuosalo, @cerminar, @cmsbuild, @diguida, @slava77, @ggovi, @mmusich can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Please merge this |
+1 |
Backport of the HCAL negative energy filter code
Backporting PR #8447, #8923, and #9105
The implementation of the negative energy filter was confirmed to be correct by the HCAL Noise WG using a configuration from a private database.
The filter is still not enabled, pending the GT (requested).