Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature diversity measures #117

Merged
merged 12 commits into from
Dec 18, 2021
Merged

Feature diversity measures #117

merged 12 commits into from
Dec 18, 2021

Conversation

LaraFuhrmann
Copy link
Collaborator

This PR consists of a new feature that is computing a selection of diversity indices based on SNVs. It should be ready to merge.

Copy link
Contributor

@kpj kpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! I added a few comments.
In addition, could you check that the diversity measures are also computed when the GitHub Actions tests run?

@LaraFuhrmann LaraFuhrmann requested a review from kpj December 17, 2021 18:00
@kpj kpj merged commit c5ef32b into master Dec 18, 2021
@DrYak DrYak deleted the feature-diversity_measures branch February 25, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants