-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename some straggler assets #3294
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few questions and suggestions but overall this is looking good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new names who this?! lol this looks great :-)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3294 +/- ##
==========================================
+ Coverage 92.69% 92.70% +0.01%
==========================================
Files 145 145
Lines 13100 13116 +16
==========================================
+ Hits 12142 12158 +16
Misses 958 958 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬 sorry
…ent, fix ferc xbrl name order
The latest commit:
There are a couple of remaining issues:
|
Ah okay I see what you're saying about the Thus far I think the concept has focused on energy-system specific entities that typically show up in a number of different contexts, often in association with a lot of denormalized data that isn't necessarily internally consistent, and the "entity" that we extract is our best guess at the correct canonical values that should be associated with the entity. Other "entities" I could imagine us introducing someday might include: smokestacks (emissions units), water cooling systems, natural gas pipeline compressors, LNG liquefaction facilities, or underground storage sites from PHMSA, coal mines from MSHA, electric substations, ISOs/RTOs, NERC regions, etc. I'll respond over in the alembic discussion. |
That's fair! If calling census areas entities would greatly expand the definition of what an entity is PUDL, then I'm down to restrict its use to just energy system topics: smoke stacks, substations, plants, generators... I'll remove entity from the census assets and recreate the migrations. |
Ok I removed "entity" from the census assets and recreated the migrations. I also made the census assets plural. |
Overview
This PR renames some straggler assets we missed in #2818. I double checked all assets follow the new naming convention.
The only remaining task is to figure out if we want to use a word or phrase other than
exploded
.Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list