Skip to content

Commit

Permalink
Merge pull request #354 from dx/fix-datacollector-configuration
Browse files Browse the repository at this point in the history
Temp replace api for compile for DataCollector jars
  • Loading branch information
demerino authored and GitHub Enterprise committed Jul 10, 2018
2 parents a2990da + 2fde333 commit c05c41e
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
7 changes: 6 additions & 1 deletion BraintreeDataCollector/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ android {
}

dependencies {
api files('libs/' + deviceCollectorVersion)
// TODO `api` is the proper keyword for this dependency
// Although when we try to add this to our releaseJar
// We don't have access to configurations.(compile|api)
// So this needs more investigation.
// For now, revert back to `compile` keyword
compile files('libs/' + deviceCollectorVersion)
}

/* maven deploy + signing */
Expand Down
7 changes: 6 additions & 1 deletion PayPalDataCollector/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ android {
dependencies {
compileOnly 'com.android.support:support-annotations:26.0.0'

api files('libs/' + dataCollectorVersion)
// TODO `api` is the proper keyword for this dependency
// Although when we try to add this to our releaseJar
// We don't have access to configurations.(compile|api)
// So this needs more investigation.
// For now, revert back to `compile` keyword
compile files('libs/' + dataCollectorVersion)

androidTestImplementation 'com.android.support.test:runner:1.0.0'
}
Expand Down

0 comments on commit c05c41e

Please sign in to comment.