Skip to content

Commit

Permalink
Temp replace api for compile
Browse files Browse the repository at this point in the history
api is not accessible during artifact building
so the data collector jars are not transitively making it
into the release jar
  • Loading branch information
quinnjn committed Jul 5, 2018
1 parent bd6c8d4 commit 2fde333
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
7 changes: 6 additions & 1 deletion BraintreeDataCollector/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ android {
}

dependencies {
api files('libs/' + deviceCollectorVersion)
// TODO `api` is the proper keyword for this dependency
// Although when we try to add this to our releaseJar
// We don't have access to configurations.(compile|api)
// So this needs more investigation.
// For now, revert back to `compile` keyword
compile files('libs/' + deviceCollectorVersion)
}

/* maven deploy + signing */
Expand Down
7 changes: 6 additions & 1 deletion PayPalDataCollector/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,12 @@ android {
dependencies {
compileOnly 'com.android.support:support-annotations:26.0.0'

api files('libs/' + dataCollectorVersion)
// TODO `api` is the proper keyword for this dependency
// Although when we try to add this to our releaseJar
// We don't have access to configurations.(compile|api)
// So this needs more investigation.
// For now, revert back to `compile` keyword
compile files('libs/' + dataCollectorVersion)

androidTestImplementation 'com.android.support.test:runner:1.0.0'
}
Expand Down

0 comments on commit 2fde333

Please sign in to comment.