PR Comments addressed

balancer · Jul 17, 2023 · 83553cc · 83553cc
1 parent f730a0a
commit 83553cc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/contracts/BaseRateProviderFactory.sol b/contracts/BaseRateProviderFactory.sol
@@ -17,15 +17,13 @@ pragma solidity ^0.8.0;
 import "./interfaces/IBaseRateProviderFactory.sol";
 
 /**
- * @title Chainlink Rate Provider Factory
- * @notice Factory for creating ChainlinkRateProviders
- * @dev This contract is used to create ChainlinkRateProvider contracts.
- *      RateProviders created by this factory are to be used in environments
- *      where the Chainlink registry is not available.
+ * @title Base Rate Provider Factory
+ * @notice Base Factory for creating RateProviders
+ * @dev This is a base contract for building factories that create RateProviders.
  */
 contract BaseRateProviderFactory is IBaseRateProviderFactory {
     // Mapping of rate providers created by this factory.
-    mapping(address => bool) internal _factoryCreatedRateProviders;
+    mapping(address => bool) private _factoryCreatedRateProviders;
 
     event RateProviderCreated(address indexed rateProvider);
 

diff --git a/contracts/ChainlinkRateProviderFactory.sol b/contracts/ChainlinkRateProviderFactory.sol
@@ -34,7 +34,6 @@ contract ChainlinkRateProviderFactory is BaseRateProviderFactory {
     function create(AggregatorV3Interface feed) external returns (ChainlinkRateProvider) {
         ChainlinkRateProvider rateProvider = new ChainlinkRateProvider(feed);
         _onCreate(address(rateProvider));
-
         return rateProvider;
     }
 }