Move repeat logic to BaseRateProvider _onCreate

balancer · Jul 17, 2023 · f730a0a · f730a0a
1 parent d8bf17c
commit f730a0a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/contracts/BaseRateProviderFactory.sol b/contracts/BaseRateProviderFactory.sol
@@ -32,4 +32,9 @@ contract BaseRateProviderFactory is IBaseRateProviderFactory {
     function isRateProviderFromFactory(address rateProvider) external view returns (bool) {
         return _factoryCreatedRateProviders[rateProvider];
     }
+
+    function _onCreate(address rateProvider) internal {
+        _factoryCreatedRateProviders[rateProvider] = true;
+        emit RateProviderCreated(rateProvider);
+    }
 }
diff --git a/contracts/ChainlinkRateProviderFactory.sol b/contracts/ChainlinkRateProviderFactory.sol
@@ -33,9 +33,7 @@ contract ChainlinkRateProviderFactory is BaseRateProviderFactory {
      */
     function create(AggregatorV3Interface feed) external returns (ChainlinkRateProvider) {
         ChainlinkRateProvider rateProvider = new ChainlinkRateProvider(feed);
-        _factoryCreatedRateProviders[address(rateProvider)] = true;
-
-        emit RateProviderCreated(address(rateProvider));
+        _onCreate(address(rateProvider));
 
         return rateProvider;
     }