Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Add unsigned int sanitization #2139

Closed
wants to merge 6 commits into from
+24 −8
Closed

[DRAFT] Add unsigned int sanitization #2139

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f1a597
added unsigned int sanitization
smittals2 Jan 24, 2025
d32908f
modified unsigned int options in the repo
smittals2 Jan 27, 2025
e3f1c10
narrowed down exclusions
smittals2 Jan 28, 2025
caac874
explicitly block sanitization in intentional spots
smittals2 Jan 28, 2025
c951f1e
clang specific macro
smittals2 Jan 28, 2025
e59eb6b
suppress erroneous outputs
smittals2 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,15 +710,14 @@ if(UBSAN)
message(FATAL_ERROR "Cannot enable UBSAN unless using Clang")
endif()

set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fsanitize=undefined")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fsanitize=undefined")

set(SANITIZER_FLAGS "-fsanitize=undefined,unsigned-integer-overflow")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a comment about why unsigned-integer-overflow is listed (and not other options)? We might also reference the clang documentation.

I was going to ask why signed-integer-overflow was not included then saw that it's covered by -fsanitize=undefined:

-fsanitize=undefined: All of the checks listed above other than float-divide-by-zero, unsigned-integer-overflow, implicit-conversion, local-bounds and the nullability-* group of checks.

if(NOT UBSAN_RECOVER)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fno-sanitize-recover=undefined")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-sanitize-recover=undefined")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fno-sanitize-recover=undefined")
set(SANITIZER_FLAGS "${SANITIZER_FLAGS} -fno-sanitize-recover=undefined,unsigned-integer-overflow")
endif()

set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${SANITIZER_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${SANITIZER_FLAGS}")
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${SANITIZER_FLAGS}")
endif()

if(GCOV)
Expand Down
Loading