-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Add unsigned int sanitization #2139
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2139 +/- ##
==========================================
+ Coverage 78.75% 78.96% +0.21%
==========================================
Files 598 611 +13
Lines 103656 105500 +1844
Branches 14720 14938 +218
==========================================
+ Hits 81635 83311 +1676
- Misses 21368 21536 +168
Partials 653 653 ☔ View full report in Codecov by Sentry. |
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined") | ||
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fsanitize=undefined") | ||
|
||
set(SANITIZER_FLAGS "-fsanitize=undefined,unsigned-integer-overflow") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add a comment about why unsigned-integer-overflow
is listed (and not other options)? We might also reference the clang documentation.
I was going to ask why signed-integer-overflow
was not included then saw that it's covered by -fsanitize=undefined
:
-fsanitize=undefined
: All of the checks listed above other thanfloat-divide-by-zero
,unsigned-integer-overflow
,implicit-conversion
,local-bounds
and thenullability-*
group of checks.
Issues:
Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2
Description of changes:
Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.