Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow storage update operation to unavailable db instance #200

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

michaelhtm
Copy link
Member

Issue #2214

Description of changes:
With this change we allow the controller to make a storage update
call when the DB instance is unavailable due to a storage-full status.

This case is not easy to test, since the minimum storage to allocate is 20GiB.
Options for testing:

  • Create an existing DB instance that is already unavailable due to storage-full
    status and update storage (this would then require us to fill up the remaining space)

more ideas are welcome...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and jaypipes November 25, 2024 17:33
With this change we allow the controller to make a storage update
call when the DB instance is unavailable due to a `storage-full` status.
Copy link

ack-prow bot commented Nov 25, 2024

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rds-verify-attribution ab5af3a link false /test rds-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
Copy link

ack-prow bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Nov 25, 2024
@ack-prow ack-prow bot merged commit cfe16d6 into aws-controllers-k8s:main Nov 25, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants