Allow storage update operation to unavailable db instance

With this change we allow the controller to make a storage update call when the DB instance is unavailable due to a `storage-full` status.
aws-controllers-k8s · Nov 25, 2024 · 0c957f4 · 0c957f4
1 parent ee3d577
commit 0c957f4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/apis/v1alpha1/ack-generate-metadata.yaml b/apis/v1alpha1/ack-generate-metadata.yaml
@@ -1,5 +1,5 @@
 ack_generate_info:
-  build_date: "2024-10-10T04:05:06Z"
+  build_date: "2024-11-25T17:27:34Z"
   build_hash: 36c2d234498c2bc4f60773ab8df632af4067f43b
   go_version: go1.23.2
   version: v0.39.1

diff --git a/pkg/resource/db_instance/sdk.go b/pkg/resource/db_instance/sdk.go
diff --git a/templates/hooks/db_instance/sdk_update_pre_build_request.go.tpl b/templates/hooks/db_instance/sdk_update_pre_build_request.go.tpl
@@ -14,7 +14,7 @@
 		ackcondition.SetSynced(desired, corev1.ConditionTrue, nil, nil)
 		return desired, nil
 	}
-	if !instanceAvailable(latest) {
+	if !instanceAvailable(latest) && !strings.Contains(*latest.ko.Status.DBInstanceStatus, "storage-full") && !delta.DifferentAt("Spec.AllocatedStorage") {
 		msg := "DB instance cannot be modifed while in '" + *latest.ko.Status.DBInstanceStatus + "' status"
 		ackcondition.SetSynced(desired, corev1.ConditionFalse, &msg, nil)
 		return desired, requeueWaitUntilCanModify(latest)