Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add ansible installation, update manual artifact download process #4675

Merged
merged 3 commits into from
May 2, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Apr 30, 2024

Description

This PR adds the manual installation steps for the ansible and adds a new playbook for downloading artifacts.

Current manual artifact download instructions are getting out of hand and it makes more sense to just use a separate playbook just for downloading these files.

Also used these steps from the autoware/setup-dev-env.sh to install ansible.

cc. @doganulus

Tests performed

Remove the ~/autoware_data folder.

Run the updated instructions to download the artifacts.

It should create and populate the folder.

Effects on system behavior

None.

Interface changes

None.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx requested a review from mitsudome-r as a code owner April 30, 2024 19:30
@xmfcx xmfcx requested a review from esteve April 30, 2024 19:30
@xmfcx xmfcx self-assigned this Apr 30, 2024
@xmfcx xmfcx added the type:installation Issues or improvements related to the installation process of the software. label Apr 30, 2024
Signed-off-by: M. Fatih Cırıt <[email protected]>
@esteve
Copy link
Contributor

esteve commented May 2, 2024

@xmfcx if I'm understanding the changes correctly, the goal is to not have manual instructions anymore and only use ansible, right?

@xmfcx
Copy link
Contributor Author

xmfcx commented May 2, 2024

if I'm understanding the changes correctly, the goal is to not have manual instructions anymore and only use ansible, right?

@esteve At least for this task, since it only downloads and extracts a long list of files, as long as we only keep it as a single role in a playbook, it should be fine to have it this way.

It is more manual than calling the setup-dev-env.sh but it is more automatic than calling download instructions line by line.

Signed-off-by: M. Fatih Cırıt <[email protected]>
Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmfcx LGTM, thanks!

@xmfcx xmfcx enabled auto-merge (squash) May 2, 2024 09:02
@xmfcx xmfcx merged commit a79ef50 into main May 2, 2024
13 checks passed
@xmfcx xmfcx deleted the ci/ansible-for-artifacts branch May 2, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:installation Issues or improvements related to the installation process of the software.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants