Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ml param download url #4677

Closed

Conversation

badai-nguyen
Copy link
Contributor

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@badai-nguyen badai-nguyen requested a review from YoshiRi May 1, 2024 12:22
@badai-nguyen
Copy link
Contributor Author

@xmfcx Thank you for your pointing out my mistake here.
Could I ask you to review this PR?

@xmfcx
Copy link
Contributor

xmfcx commented May 1, 2024

Sorry @badai-nguyen I should have tagged you as well on this PR from yesterday:

I've replaced this readme part with a new playbook that only downloads and extracts these files.

Could you try and if it works, approve?

@xmfcx
Copy link
Contributor

xmfcx commented May 2, 2024

Closing since:

@xmfcx xmfcx closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants