fix(autoware_map_height_fitter): find PCL package after autoware_package() is called #10070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age() is called Signed-off-by: Ryohsuke Mitsudome <[email protected]>
mitsudome-r
requested review from
anhnv3991,
isamu-takagi,
KYabuuchi,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4 and
YamatoAndo
as code owners
github-actions
bot
added
the
component:map
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mitsudome-r
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10070 +/- ##
==========================================
- Coverage 28.33% 28.32% -0.02%
==========================================
Files 1485 1489 +4
Lines 111092 111141 +49
Branches 43152 43153 +1
==========================================
Hits 31483 31483
- Misses 76588 76637 +49
Partials 3021 3021
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
isamu-takagi
approved these changes
Feb 5, 2025
youtalk
pushed a commit
that referenced
this pull request
Feb 10, 2025
…age() is called (#10070) Signed-off-by: Ryohsuke Mitsudome <[email protected]>
mitsudome-r
added a commit
to mitsudome-r/autoware.universe
that referenced
this pull request
Feb 27, 2025
…age() is called (autowarefoundation#10070) Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This package fails to build with the autoware_utils 1.1.0.
(This package depends on autoware_utils via autoware_lanelet2_extension)
Since autoware_utils is now depending on pcl as well, it overwrites some of PCL related CMAKE variables.
In order to only import intended modules, PCL should be included after calling autoware_package().
Related links
How was this PR tested?
I have tested locally that the build passes without an error.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.