Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/pinning-notes] #540

Merged
merged 10 commits into from
Nov 2, 2024
Merged

Conversation

andy-ife
Copy link

@andy-ife andy-ife commented Nov 1, 2024

Goal

This pull request adds the ability for users to pin and unpin important notes to the top of the notes list. Related issue here

Implementation Details

Key details:

  • The Note model now has an extra field: isPinned, which also adds an extra column to the database.
  • Database has been updated from v6 to v7.
  • Notes Screen now has a dynamic bottom sheet with pin and delete options.
  • Pin and unpin logic is as simple as note.isPinned = true/false, then update database.
  • Dao get methods now returns notes sorted by pinned status and dateTime.
  • Notes can also be pinned/unpinned in the AddEditScreen

Examples

See a short video of the feature here

Copy link
Owner

@aritra-tech aritra-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

@aritra-tech aritra-tech merged commit e687462 into aritra-tech:develop Nov 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants