Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for pinning notes or adding favorites #186

Closed
Kayvee08 opened this issue Oct 22, 2023 · 30 comments
Closed

Adding support for pinning notes or adding favorites #186

Kayvee08 opened this issue Oct 22, 2023 · 30 comments
Assignees
Labels
approved Approved by the maintainer & ready for dev features good first issue Good for newcomers hacktoberfest improvement
Milestone

Comments

@Kayvee08
Copy link

Users can either pin notes that the deem important to the top or make then favorites which will also show those notes at the top.

@aritra-tech
Copy link
Owner

Pin sounds better @Kayvee08

@serrq
Copy link

serrq commented Oct 22, 2023

With future tags system no needs for favorites. Just typing two-three labels in the search bar and find everything.

@Kayvee08
Copy link
Author

So should we add option to pin (important) notes ?

@serrq
Copy link

serrq commented Oct 22, 2023

Pinned notes feature brings important ones on top of the notes list. Makes sense for me.

Of course, first are the notes pinned, then those ordered according to the sorting criterion.

@aritra-tech aritra-tech added good first issue Good for newcomers features improvement approved Approved by the maintainer & ready for dev hacktoberfest labels Oct 22, 2023
@aritra-tech
Copy link
Owner

WhatsApp Image 2023-10-23 at 00 49 40_cbc549e0

I was thinking like this now on a long click there is a feature multi-delete option so I was thinking that when the user long clicks then a bottom sheet opens up with two features Delete & Pin as shown in the picture.

Is the ideas feasible @Kayvee08 @serrq ?

@serrq
Copy link

serrq commented Oct 22, 2023

Like your idea. 👌

@serrq
Copy link

serrq commented Oct 22, 2023

What is the milestone for this feature? 1.6.0?

@aritra-tech
Copy link
Owner

What is the milestone for this feature? 1.6.0?

It will be 1.7.1 ig

@Kayvee08
Copy link
Author

@aritra-tech currently we are showing the delete option in the top bar, so you are suggesting we move the option to pin and delete to the bottom bar right ?

@serrq
Copy link

serrq commented Oct 22, 2023

@aritra-tech currently we are showing the delete option in the top bar, so you are suggesting we move the option to pin and delete to the bottom bar right ?

Same question. Good point.

@aritra-tech
Copy link
Owner

@aritra-tech currently we are showing the delete option in the top bar, so you are suggesting we move the option to pin and delete to the bottom bar right ?

Yeah right.
What do you think is this idea good or you can tell what you want to do

@Kayvee08
Copy link
Author

@aritra-tech bottomsheet is a good idea, but will see how others are incorporating this feature in terms of accessibility and UI.

@aritra-tech
Copy link
Owner

Hey @serrq is the idea good to go that I have shared.

@serrq
Copy link

serrq commented Oct 22, 2023

Mmm I didn't understand your sentence. My English is so fragile. Might you change some words? You mean it is good sharing the ideas?

@aritra-tech
Copy link
Owner

WhatsApp Image 2023-10-23 at 00 49 40_cbc549e0

I was thinking like this now on a long click there is a feature multi-delete option so I was thinking that when the user long clicks then a bottom sheet opens up with two features Delete & Pin as shown in the picture.

Is the ideas feasible @Kayvee08 @serrq ?

This idea that I have told is okay for you? @serrq

@serrq
Copy link

serrq commented Oct 22, 2023

Excellent Aritra! 👌

@aritra-tech
Copy link
Owner

Hey @Kayvee08 then that's the final idea lets work on it.
All the best

@aritra-tech aritra-tech moved this to To do 🗒 in Notify Oct 22, 2023
@aritra-tech aritra-tech moved this from To do 🗒 to In progress 🚧 in Notify Oct 22, 2023
@Kayvee08
Copy link
Author

Okay, will start working on it @aritra-tech

@Kayvee08
Copy link
Author

@aritra-tech worked on this and have added the PR
#214

@aritra-tech aritra-tech modified the milestones: v1.7.1, v1.8.1 Nov 5, 2023
@purushyb
Copy link

is anybody looking into this ??, (Since #214 is not merged yet)

@aritra-tech
Copy link
Owner

No @purushyb if you want you can pick it up

@andy-ife
Copy link

Hi @aritra-tech Can I look into this as well? Seems no one has provided an acceptable solution yet.

@aritra-tech
Copy link
Owner

yeah please @andy-ife

@andy-ife
Copy link

Alright. Will keep you posted. Hoping to get my first gh contribution lol

@MianMuzammil67
Copy link

im already working on it

@andy-ife
Copy link

Hmm. What do you say @aritra-tech

@aritra-tech
Copy link
Owner

Hey @MianMuzammil67 sorry but @andy-ife is working on it
@andy-ife please continue

@andy-ife
Copy link

WhatsApp Image 2023-10-23 at 00 49 40_cbc549e0
I was thinking like this now on a long click there is a feature multi-delete option so I was thinking that when the user long clicks then a bottom sheet opens up with two features Delete & Pin as shown in the picture.
Is the ideas feasible @Kayvee08 @serrq ?

This idea that I have told is okay for you? @serrq

@aritra-tech I'll go with this implementation if that's alright

@andy-ife
Copy link

andy-ife commented Nov 1, 2024

All done @aritra-tech . Pull request #540

@aritra-tech
Copy link
Owner

I will look into the changes and merge the PR @andy-ife
Thank you

@github-project-automation github-project-automation bot moved this from In progress 🚧 to Ready 🚀 in Notify Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by the maintainer & ready for dev features good first issue Good for newcomers hacktoberfest improvement
Projects
Status: Ready 🚀
Development

No branches or pull requests

6 participants