Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14176 Add runstate information to C2 FlowInfo #9651

Closed

Conversation

martinzink
Copy link
Member

Summary

NIFI-14176
Add runstate information to C2 FlowInfo

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@martinzink martinzink added the minifi Pull requests that updates minifi/c2 codes label Jan 20, 2025
@martinzink martinzink force-pushed the NIFI-14176-c2_flowinfo_running branch from ab8a3c5 to 2c48536 Compare January 20, 2025 15:12
@@ -37,6 +37,7 @@ public class ProcessorStatus implements Serializable {
private long processingNanos;
private int activeThreadCount;
private int terminatedThreadCount;
private String runState;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for calling this runState as opposed to runStatus as named in the source Processor Status object?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly, and I think we wanna go with runStatus instead. We did indeed implement it as runStatus in c++
apache/nifi-minifi-cpp@07b9641#diff-00076823b84623f3ab4d37455b5d6943cf6becc21da552be650affcae6344abdR39

To be honest, I only created this draft PR as a discussion starter, so we can see what would be the natural way to implement this in minifi java so we can implement the same thing in minifi c++.

But it turns out the C2 command to start stop components is only present in the C++ agents so this seems to be putting the cart before the horse in the case of the java agent. I will close this, and we can add this field when we implement the start/stop C2 command.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the background @martinzink, sounds good for now.

@martinzink martinzink closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minifi Pull requests that updates minifi/c2 codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants