MINIFICPP-2501 Add processorStatuses C2 metric node to FlowInformation #1909
Conversation
lordgamez
force-pushed
the
MINIFICPP-2501
branch
3 times, most recently
from
7f2991b to
efa4f0c
Compare
|
LGTM, tried it over C2, and now it looks the same as the java agent. One thing we might want to move the FlowInfo::components::ProcessorName::running into this FlowInfo::processorStatuses struct |
Thanks for checking it out! It's a good point to move the running field to the processorStatuses node as no other fields are present there and the components node only refers to processors. I moved the running field to that node in 8a5bc25 |
C2.md
Outdated
|
|
||
| ### Processor Metric Response Nodes | ||
|
|
||
| Each processor can have its own metrics. These metric nodes can be configured in the minifi.properties by requesting metrics in the \<ProcessorType\>Metric format, for example GetTCPMetrics to request metrics for the GetTCP processors. Besides configuring processor metrics directly, they can also be configured using regular expressions with the `processorMetrics/` prefix. For example `processorMetrics/Get.*Metrics` will match all processor metrics that start with Get. |
There was a problem hiding this comment.
typo: \<ProcessorType\>Metric -> \<ProcessorType\>Metrics
There was a problem hiding this comment.
Updated in 3cb95da
| 'minifi_incoming_flow_files', 'minifi_incoming_bytes', 'minifi_bytes_read', 'minifi_bytes_written', | ||
| 'minifi_processing_nanos'], metric_class, labels) and \ | ||
| self.verify_metrics_larger_than_zero(['minifi_onTrigger_invocations', 'minifi_transferred_flow_files', 'minifi_transferred_to_success', | ||
| 'minifi_transferred_bytes', 'minifi_processing_nanos'], |
There was a problem hiding this comment.
'minifi_processing_nanos' is in both checks -- is that intentional / useful?
There was a problem hiding this comment.
Updated in 3cb95da
|
related: apache/nifi#9651 |
lordgamez
force-pushed
the
MINIFICPP-2501
branch
from
3cb95da to
c34e908
Compare
Updated to use "runningState" in C2 flowInfo with possible values "RUNNING" and "STOPPED" in c34e908 |
https://issues.apache.org/jira/browse/MINIFICPP-2501
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.