Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] feat(server): Introduce LocalFileBlackHoleWriter for test flush ceiling performance #2321

Merged
merged 3 commits into from
Jan 7, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.uniffle.storage.handler.impl;

import java.io.File;
import java.io.IOException;

import io.netty.buffer.ByteBuf;

import org.apache.uniffle.storage.api.FileWriter;
import org.apache.uniffle.storage.common.FileBasedShuffleSegment;

/** A shuffle writer that write data into black hole for performance test purpose only. */
public class LocalFileBlackHoleWriter implements FileWriter {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this class should be in the test package.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could not specify it for performance test purpose if we put it into the test package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I got it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would better add more comments to explain how to use this class.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK


private long nextOffset;

public LocalFileBlackHoleWriter(File file, int bufferSize) {}

@Override
public void writeData(byte[] data) throws IOException {
nextOffset = nextOffset + data.length;
}

@Override
public void writeData(ByteBuf buf) throws IOException {
if (buf != null && buf.readableBytes() > 0) {
nextOffset = nextOffset + buf.readableBytes();
}
}

@Override
public void writeIndex(FileBasedShuffleSegment segment) throws IOException {}

@Override
public long nextOffset() {
return nextOffset;
}

@Override
public synchronized void close() throws IOException {}
}
Loading