[MINOR] feat(server): Introduce LocalFileBlackHoleWriter for test flush ceiling performance #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2321 +/- ##
============================================
+ Coverage 51.19% 51.59% +0.39%
- Complexity 2936 2973 +37
============================================
Files 486 475 -11
Lines 24720 22692 -2028
Branches 2041 2090 +49
============================================
- Hits 12656 11708 -948
+ Misses 11274 10239 -1035
+ Partials 790 745 -45 ☔ View full report in Codecov by Sentry. |
jerqi
reviewed
Jan 6, 2025
| import org.apache.uniffle.storage.common.FileBasedShuffleSegment; | ||
|
|
||
| /** A shuffle writer that write data into black hole. */ | ||
| public class LocalFileBlackHoleWriter implements FileWriter { |
There was a problem hiding this comment.
Maybe this class should be in the test package.
There was a problem hiding this comment.
We could not specify it for performance test purpose if we put it into the test package.
There was a problem hiding this comment.
You would better add more comments to explain how to use this class.
…used for performance test purpose only
|
@jerqi Add more comments. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce a new implementation of FileWriter, named
LocalFileBlackHoleWriter.Why are the changes needed?
Drop all the data, specify
LocalFileBlackHoleWriterfor test the ceiling performance of flush event.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested on our pressure cluster.