Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: run zepter checks for features of non-workspace dependencies #2144

Merged
merged 4 commits into from
Mar 5, 2025
Merged

fix: run zepter checks for features of non-workspace dependencies #2144

merged 4 commits into from
Mar 5, 2025

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Mar 5, 2025

Motivation

--workspace results in zepter not checking whether features are propagated to non-workspace deps

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@klkvr
Copy link
Member Author

klkvr commented Mar 5, 2025

blocked by rayon-rs/either#119

@klkvr
Copy link
Member Author

klkvr commented Mar 5, 2025

Enabling similar-asserts/serde results in some weird issues for --no-default-feature --workspace builds, will configure zepter to only enforce propagation to normal vs dev dependencies.

@klkvr klkvr merged commit 04ab8d6 into main Mar 5, 2025
27 checks passed
@klkvr klkvr deleted the klkvr/zepter branch March 5, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Alloy
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse