fix: run zepter checks for features of non-workspace dependencies (#2144

) * fix: run zepter for non-workspace dependencies * bump either * zepter * fix
alloy-rs · Mar 5, 2025 · 04ab8d6 · 04ab8d6
1 parent 6565ba7
commit 04ab8d6
Show file tree

Hide file tree

Showing 9 changed files with 75 additions and 29 deletions.
diff --git a/.config/zepter.yaml b/.config/zepter.yaml
@@ -17,8 +17,9 @@ workflows:
         "--left-side-feature-missing=ignore",
         # Ignore the case that `A` it outside of the workspace. Otherwise it will report errors in external dependencies that we have no influence on.
         "--left-side-outside-workspace=ignore",
-        # limit to the workspace
-        "--workspace",
+        # Only check normal dependencies. 
+        # Propagating to dev-dependencies leads to compilation issues: https://github.com/alloy-rs/alloy/pull/2144#issuecomment-2702291349
+        "--dep-kinds=normal:check,dev:ignore",
         "--show-path",
         "--quiet",
       ]

diff --git a/Cargo.toml b/Cargo.toml
@@ -136,7 +136,7 @@ base64 = "0.22"
 bimap = "0.6"
 cfg-if = "1"
 derive_more = { version = "2", default-features = false }
-either = { version = "1.13", default-features = false }
+either = { version = "1.15", default-features = false }
 home = "0.5"
 http = "1.1.0"
 itertools = { version = ">=0.13, <=0.14", default-features = false }

diff --git a/crates/consensus-any/Cargo.toml b/crates/consensus-any/Cargo.toml
@@ -43,7 +43,10 @@ default = ["std"]
 std = [
 	"alloy-eips/std",
 	"alloy-consensus/std",
-	"alloy-serde?/std"
+	"alloy-serde?/std",
+	"alloy-primitives/std",
+	"alloy-rlp/std",
+	"serde?/std"
 ]
 arbitrary = ["std", "dep:arbitrary", "alloy-eips/arbitrary"]
 serde = [

diff --git a/crates/consensus/Cargo.toml b/crates/consensus/Cargo.toml
@@ -52,7 +52,7 @@ derive_more = { workspace = true, features = [
 ], default-features = false }
 auto_impl.workspace = true
 thiserror.workspace = true
-either = { workspace = true }
+either.workspace = true
 
 [dev-dependencies]
 alloy-eips = { workspace = true, features = ["arbitrary"] }
@@ -67,15 +67,33 @@ tokio = { workspace = true, features = ["macros"] }
 
 [features]
 default = ["std"]
-std = ["alloy-eips/std", "c-kzg?/std", "alloy-serde?/std"]
+std = [
+	"alloy-eips/std",
+	"c-kzg?/std",
+	"alloy-serde?/std",
+	"alloy-primitives/std",
+	"alloy-rlp/std",
+	"alloy-trie/std",
+	"derive_more/std",
+	"k256?/std",
+	"serde?/std",
+	"serde_json/std",
+	"serde_with?/std",
+	"thiserror/std",
+	"either/std"
+]
 k256 = ["dep:k256", "alloy-primitives/k256", "alloy-eips/k256"]
 kzg = ["dep:c-kzg", "alloy-eips/kzg", "std"]
 arbitrary = ["std", "dep:rand", "dep:arbitrary", "alloy-eips/arbitrary"]
 serde = [
-    "dep:serde",
-    "alloy-primitives/serde",
-    "dep:alloy-serde",
-    "alloy-eips/serde",
-    "alloy-trie/serde",
+	"dep:serde",
+	"alloy-primitives/serde",
+	"dep:alloy-serde",
+	"alloy-eips/serde",
+	"alloy-trie/serde",
+	"c-kzg?/serde",
+	"either/serde",
+	"k256?/serde",
+	"rand?/serde"
 ]
 serde-bincode-compat = ["alloy-eips/serde-bincode-compat", "serde_with"]
diff --git a/crates/eips/Cargo.toml b/crates/eips/Cargo.toml
@@ -71,20 +71,30 @@ rand.workspace = true
 [features]
 default = ["std", "kzg-sidecar"]
 std = [
-    "alloy-primitives/std",
-    "alloy-rlp/std",
-    "serde?/std",
-    "c-kzg?/std",
-    "once_cell?/std",
-    "alloy-serde?/std",
+	"alloy-primitives/std",
+	"alloy-rlp/std",
+	"serde?/std",
+	"c-kzg?/std",
+	"once_cell?/std",
+	"alloy-serde?/std",
+	"alloy-eip2124/std",
+	"alloy-eip2930/std",
+	"alloy-eip7702/std",
+	"derive_more/std",
+	"serde_json/std",
+	"sha2?/std",
+	"either/std"
 ]
 serde = [
-    "dep:alloy-serde",
-    "dep:serde",
-    "alloy-primitives/serde",
-    "c-kzg?/serde",
-    "alloy-eip2930/serde",
-    "alloy-eip7702/serde",
+	"dep:alloy-serde",
+	"dep:serde",
+	"alloy-primitives/serde",
+	"c-kzg?/serde",
+	"alloy-eip2930/serde",
+	"alloy-eip7702/serde",
+	"alloy-eip2124/serde",
+	"either/serde",
+	"rand/serde"
 ]
 serde-bincode-compat = ["alloy-eip7702/serde-bincode-compat"]
 kzg = ["kzg-sidecar", "sha2", "dep:c-kzg", "dep:once_cell"]

diff --git a/crates/genesis/Cargo.toml b/crates/genesis/Cargo.toml
@@ -41,5 +41,6 @@ std = [
 	"alloy-serde/std",
 	"serde/std",
 	"alloy-trie/std",
-	"alloy-eips/std"
+	"alloy-eips/std",
+	"serde_json/std"
 ]
diff --git a/crates/network-primitives/Cargo.toml b/crates/network-primitives/Cargo.toml
@@ -39,5 +39,6 @@ std = [
 	"alloy-primitives/std",
 	"alloy-consensus/std",
 	"alloy-eips/std",
-	"alloy-serde/std"
+	"alloy-serde/std",
+	"serde/std"
 ]
diff --git a/crates/rpc-types-engine/Cargo.toml b/crates/rpc-types-engine/Cargo.toml
@@ -55,13 +55,19 @@ std = [
 	"derive_more/std",
 	"strum/std",
 	"alloy-eips/std",
-	"alloy-serde?/std"
+	"alloy-serde?/std",
+	"alloy-primitives/std",
+	"alloy-rlp/std",
+	"serde?/std",
+	"serde_json/std"
 ]
 serde = [
 	"dep:serde",
 	"dep:alloy-serde",
 	"alloy-consensus/serde",
-	"alloy-eips/serde"
+	"alloy-eips/serde",
+	"alloy-primitives/serde",
+	"rand?/serde",
 ]
 jwt = ["std", "dep:jsonwebtoken", "dep:rand"]
 jsonrpsee-types = ["dep:jsonrpsee-types"]

diff --git a/crates/rpc-types-eth/Cargo.toml b/crates/rpc-types-eth/Cargo.toml
@@ -68,7 +68,12 @@ std = [
 	"alloy-eips/std",
 	"alloy-consensus-any/std",
 	"alloy-network-primitives/std",
-	"alloy-serde?/std"
+	"alloy-serde?/std",
+	"alloy-rlp/std",
+	"alloy-sol-types/std",
+	"serde?/std",
+	"serde_json?/std",
+	"thiserror/std"
 ]
 serde = [
 	"dep:serde",
@@ -77,7 +82,8 @@ serde = [
 	"alloy-primitives/serde",
 	"alloy-consensus/serde",
 	"alloy-eips/serde",
-	"alloy-consensus-any/serde"
+	"alloy-consensus-any/serde",
+	"rand/serde",
 ]
 arbitrary = [
     "std",