Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't detach completion popup while typing when prefix is empty #5517

Merged
merged 11 commits into from
Mar 22, 2024
Merged

fix: don't detach completion popup while typing when prefix is empty #5517

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
12816e2
fix: swap blue/red in cloudeditor themes to reduces usage of red
akoreman Mar 1, 2024
2a705ca
fix: scroll cursor to top for long inline preview
akoreman Mar 19, 2024
3f084f5
Merge branch 'ajaxorg:master' into inline_scroll_fix
akoreman Mar 19, 2024
0577f43
fix: calculation of pixels to scroll top in setGhostText
akoreman Mar 20, 2024
8ea518a
revert: changes to pixelposition calc
akoreman Mar 20, 2024
3e13c31
fix: whitespace
akoreman Mar 20, 2024
de82b03
fix: don't detach completer when slow results come in on non-prefix p…
akoreman Mar 20, 2024
8085811
Merge branch 'ajaxorg:master' into inline_fix
akoreman Mar 20, 2024
a3eb777
fix: don't detach popup when prefix is empty and keep keepPopupPositi…
akoreman Mar 21, 2024
373bbef
Merge branch 'ajaxorg:master' into inline_fix
akoreman Mar 22, 2024
95ad570
fix: close popup when backspacing to no prefix
akoreman Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/autocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,8 +362,6 @@ class Autocomplete {
if (this.tooltipNode) {
this.updateDocTooltip();
}
} else if (keepPopupPosition && !prefix) {
this.detach();
akoreman marked this conversation as resolved.
Show resolved Hide resolved
}
this.changeTimer.cancel();
this.observeLayoutChanges();
Expand Down
14 changes: 11 additions & 3 deletions src/autocomplete_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"use strict";

var sendKey = require("./test/user").type;
var {buildDom} = require("./lib/dom");

Check warning on line 8 in src/autocomplete_test.js

View workflow job for this annotation

GitHub Actions / build (16.x) 

'buildDom' is assigned a value but never used
var ace = require("./ace");
var assert = require("./test/assertions");
var user = require("./test/user");
Expand Down Expand Up @@ -487,6 +487,7 @@
}
];

user.type(" ");
user.type("t");
user.type("e");
assert.ok(!editor.completer || !editor.completer.popup.isOpen);
Expand All @@ -495,9 +496,16 @@
assert.ok(editor.completers[1].timeout);
user.type("Home");
setTimeout(function() {
assert.ok(!editor.completer.popup.isOpen);
assert.ok(!editor.completers[1].timeout);
done();
assert.ok(editor.completer.popup.isOpen);
assert.ok(editor.completers[1].timeout);

user.type("Left");

setTimeout(function() {
assert.ok(!editor.completer.popup.isOpen);
assert.ok(!editor.completers[1].timeout);
done();
}, 0);
}, 0);
}, 11);
},
Expand Down
Loading